Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing format fields to m.room.message$m.notice schema. #2125

Merged
merged 1 commit into from Jun 12, 2019

Conversation

@jimmycuadra
Copy link
Contributor

jimmycuadra commented Jun 12, 2019

The example event shows the format and formatted_body fields like the m.text message type, but these fields do not appear in the schema shown above the example.

Copy link
Member

turt2live left a comment

Thanks! Per the contributing guidelines can we get a sign off and changelog entry please?

Signed-off-by: Jimmy Cuadra <jimmy@jimmycuadra.com>
@jimmycuadra jimmycuadra force-pushed the jimmycuadra:m.notice-format branch from ff60798 to e670fb1 Jun 12, 2019
@jimmycuadra

This comment has been minimized.

Copy link
Contributor Author

jimmycuadra commented Jun 12, 2019

Done. It'd be useful to explain the changelog system a little better in the contributing guide. The fact that changelogs/client_server/newsfragments is empty in the repository is confusing. I had to look at another accepted pull request to see if I was doing it right, which adds some friction to contributing. Also, the contributing guide says that only the client-server spec is stable, which is no longer true!

@turt2live

This comment has been minimized.

Copy link
Member

turt2live commented Jun 12, 2019

Normally it does have other fragments in it, but after a release it's fairly empty and boring :(

The contributing guide definitely needs an update though, and not just because it says only the CS API is stable.

@turt2live turt2live merged commit a9297f9 into matrix-org:master Jun 12, 2019
7 checks passed
7 checks passed
ci/circleci: build-dev-scripts Your tests passed on CircleCI!
Details
ci/circleci: build-docs Your tests passed on CircleCI!
Details
ci/circleci: build-swagger Your tests passed on CircleCI!
Details
ci/circleci: check-docs Your tests passed on CircleCI!
Details
ci/circleci: validate-docs Your tests passed on CircleCI!
Details
docs Click details to preview the HTML documentation.
Details
swagger Click to preview the swagger build.
Details
@jimmycuadra jimmycuadra deleted the jimmycuadra:m.notice-format branch Jun 13, 2019
@jplatte jplatte referenced this pull request Nov 9, 2019
1 of 21 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.