Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSC2140: Terms of Service for ISes and IMs #2140

Open
wants to merge 55 commits into
base: master
from

Conversation

Projects
None yet
5 participants

dbkr added some commits Jun 20, 2019

@dbkr dbkr requested a review from matrix-org/spec-core-team Jun 20, 2019

@turt2live
Copy link
Member

left a comment

largely looks fine to me - I have some concerns about storing URLs rather than other identifiers, as demonstrated by the comments.

Show resolved Hide resolved proposals/2140-terms-of-service-2.md Outdated
and version keys, however, are used only to provide a human-readable
description of the document to the user.

In the IM API, the client should provide authentication for this endpoint.

This comment has been minimized.

Copy link
@turt2live

turt2live Jun 20, 2019

Member

For readers: This would be done through https://github.com/turt2live/matrix-dimension/blob/master/docs/reference/scalar_auth.md at the moment, but in future could be #1961

Show resolved Hide resolved proposals/2140-terms-of-service-2.md
Show resolved Hide resolved proposals/2140-terms-of-service-2.md
Show resolved Hide resolved proposals/2140-terms-of-service-2.md
Show resolved Hide resolved proposals/2140-terms-of-service-2.md Outdated
Show resolved Hide resolved proposals/2140-terms-of-service-2.md Outdated
Show resolved Hide resolved proposals/2140-terms-of-service-2.md
Show resolved Hide resolved proposals/2140-terms-of-service-2.md

@turt2live turt2live requested a review from matrix-org/spec-core-team Jun 20, 2019

dbkr and others added some commits Jun 21, 2019

Typo
Co-Authored-By: Travis Ralston <travpc@gmail.com>

@turt2live turt2live changed the title Terms of Service for ISes and IMs MSC2140: Terms of Service for ISes and IMs Jun 21, 2019

@richvdh
Copy link
Member

left a comment

looks generally sensible, though I think the discussion about whether to identify docs by their URLs or something else needs needs resolving.

Show resolved Hide resolved proposals/2140-terms-of-service-2.md Outdated
Show resolved Hide resolved proposals/2140-terms-of-service-2.md Outdated

dbkr and others added some commits Jun 24, 2019

Linkify
Co-Authored-By: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
m.third_party_terms -> m.accepted_terms
as it will have the HS's terms too
HS docs must be added too
also, unbind must not error when called by HSes and proxy terms token
GET terms must be unauthed.
Detail process for new auth (don't register until consent given).

Specifically mention the authentication header.
Use M_CONSENT_NOT_GIVEN
No idea where I got the other one from: we already have one in the
spec, so use it.
@turt2live
Copy link
Member

left a comment

I like this approach much better than the custom header approach. It certainly makes it easier to implement, even if the dance is harder to do.

Show resolved Hide resolved proposals/2140-terms-of-service-2.md Outdated
Show resolved Hide resolved proposals/2140-terms-of-service-2.md Outdated
Show resolved Hide resolved proposals/2140-terms-of-service-2.md Outdated
Show resolved Hide resolved proposals/2140-terms-of-service-2.md Outdated
Show resolved Hide resolved proposals/2140-terms-of-service-2.md Outdated
Show resolved Hide resolved proposals/2140-terms-of-service-2.md Outdated
Show resolved Hide resolved proposals/2140-terms-of-service-2.md Outdated
Show resolved Hide resolved proposals/2140-terms-of-service-2.md Outdated
Show resolved Hide resolved proposals/2140-terms-of-service-2.md Outdated
Show resolved Hide resolved proposals/2140-terms-of-service-2.md

dbkr and others added some commits Jul 2, 2019

both registers are excluded from auth
Co-Authored-By: Travis Ralston <travpc@gmail.com>
Typo
Co-Authored-By: Travis Ralston <travpc@gmail.com>
slash
Co-Authored-By: Travis Ralston <travpc@gmail.com>
slash
Co-Authored-By: Travis Ralston <travpc@gmail.com>
fullstop
Co-Authored-By: Travis Ralston <travpc@gmail.com>
@turt2live
Copy link
Member

left a comment

thanks for suffering my random editorial hat

A client uses this client/server API endpoint to request that the Homeserver
removes the given 3PID from the given Identity Server, or all Identity Servers.
Takes parameters the same parameters as
`POST /_matrix/client/r0/account/3pid/delete`, ie. `id_server`, `medium`,

This comment has been minimized.

Copy link
@turt2live

turt2live Jul 5, 2019

Member

Should we just deprecate the delete endpoint?

This comment has been minimized.

Copy link
@dbkr

dbkr Jul 12, 2019

Author Member

It's still needed for clients to remove the 3pid from the HS though?

dbkr and others added some commits Jul 10, 2019

typo
Co-Authored-By: J. Ryan Stinnett <jryans@gmail.com>
unnecessary capital
Co-Authored-By: J. Ryan Stinnett <jryans@gmail.com>
unnecessary capital mk. 2
Co-Authored-By: J. Ryan Stinnett <jryans@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.