Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSC2174: Move the `redacts` key to a sane place #2174

Merged
merged 3 commits into from Aug 3, 2019

Conversation

@richvdh
Copy link
Member

commented Jul 14, 2019

Rendered.

This would fix #502.

richvdh added some commits Jul 14, 2019

@richvdh richvdh changed the title Proposal to move the `redacts` key to a sane place MSC2174: Move the `redacts` key to a sane place Jul 14, 2019

@turt2live turt2live self-requested a review Jul 14, 2019

@KitsuneRal

This comment has been minimized.

Copy link
Member

commented Jul 15, 2019

I suppose this change can be bundled with other stuff that would need a new room version. From the client perspective I don't see a big problem (though that will probably be the first case when I'll have to parse events differently depending on which room, i.e. of which version, they arrive to).

@richvdh

This comment has been minimized.

Copy link
Member Author

commented Jul 22, 2019

I'd quite like to call FCP on this soonish. It seems relatively uncontentious.

@richvdh

This comment has been minimized.

Copy link
Member Author

commented Jul 26, 2019

@mscbot fcp merge

@mscbot

This comment has been minimized.

Copy link
Collaborator

commented Jul 26, 2019

Team member @richvdh has proposed to merge this. The next step is review by the rest of the tagged people:

No concerns currently listed.

Once a majority of reviewers approve (and none object), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@mscbot

This comment has been minimized.

Copy link
Collaborator

commented Jul 29, 2019

🔔 This is now entering its final comment period, as per the review above. 🔔

@mscbot

This comment has been minimized.

Copy link
Collaborator

commented Aug 3, 2019

The final comment period, with a disposition to merge, as per the review above, is now complete.

@turt2live turt2live merged commit a71757f into master Aug 3, 2019

7 checks passed

buildkite/matrix-doc Build #529 passed (1 minute, 5 seconds)
Details
ci/circleci: build-dev-scripts Your tests passed on CircleCI!
Details
ci/circleci: build-docs Your tests passed on CircleCI!
Details
ci/circleci: build-swagger Your tests passed on CircleCI!
Details
ci/circleci: check-docs Your tests passed on CircleCI!
Details
ci/circleci: validate-docs Your tests passed on CircleCI!
Details
docs Click details to preview the HTML documentation.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.