Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSC2175: Remove the `creator` field from `m.room.create` events #2175

Merged
merged 3 commits into from Jul 31, 2019

Conversation

@richvdh
Copy link
Member

commented Jul 14, 2019

Rendered

Fixes #1193

@richvdh richvdh changed the title Proposal to remove the `creator` field MSC2175: Remove the `creator` field from `m.room.create` events Jul 14, 2019

@turt2live turt2live self-requested a review Jul 14, 2019

@KitsuneRal

This comment has been minimized.

Copy link
Member

commented Jul 15, 2019

No objections from the client perspective.

@turt2live
Copy link
Member

left a comment

finally, thank you!

@richvdh

This comment has been minimized.

Copy link
Member Author

commented Jul 22, 2019

I'm going to assume that the only reason not to do this is tuits, so

@mscbot fcp merge

@mscbot

This comment has been minimized.

Copy link
Collaborator

commented Jul 22, 2019

Team member @richvdh has proposed to merge this. The next step is review by the rest of the tagged people:

No concerns currently listed.

Once a majority of reviewers approve (and none object), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@anoadragon453

This comment has been minimized.

Copy link
Member

commented Jul 25, 2019

Looks like a good cleanup, thanks.

@mscbot reviewed

@mscbot

This comment has been minimized.

Copy link
Collaborator

commented Jul 25, 2019

🔔 This is now entering its final comment period, as per the review above. 🔔

@ara4n

This comment has been minimized.

Copy link
Member

commented Jul 25, 2019

fwiw, the reason for the creator field was i think to support moving creator ownership around in subsequent events somehow. but given this has never been figured out, i’m happy to remove the redundancy and readd correctly jn future if needed

@mscbot

This comment has been minimized.

Copy link
Collaborator

commented Jul 31, 2019

The final comment period, with a disposition to merge, as per the review above, is now complete.

@anoadragon453 anoadragon453 merged commit 0c7c48b into master Jul 31, 2019

8 checks passed

buildkite/matrix-doc Build #505 passed (57 seconds)
Details
ci/circleci: build-dev-scripts Your tests passed on CircleCI!
Details
ci/circleci: build-docs Your tests passed on CircleCI!
Details
ci/circleci: build-swagger Your tests passed on CircleCI!
Details
ci/circleci: check-docs Your tests passed on CircleCI!
Details
ci/circleci: validate-docs Your tests passed on CircleCI!
Details
docs Click details to preview the HTML documentation.
Details
swagger Click to preview the swagger build.
Details

@turt2live turt2live self-assigned this Jul 31, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.