Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSC2192: Inline widgets (including polls and buttons) #2192

Open
wants to merge 4 commits into
base: master
from

Conversation

@turt2live
Copy link
Member

commented Jul 28, 2019

Rendered

Disclaimer: This is currently a set of ideas and may not be complete or ideal.

Early implementation: matrix-org/matrix-react-sdk#3252
For vector-im/riot-web#10060 and related issues.

@turt2live turt2live added the proposal label Jul 28, 2019

@turt2live turt2live changed the title Inline widgets (including polls and buttons) MSC2192: Inline widgets (including polls and buttons) Jul 28, 2019

by blocking the widget from loading until the user accepts the widget.

Polls should not be used for important matters like voting for presidents or cabinet members.

This comment has been minimized.

Copy link
@uhoreg

uhoreg Aug 18, 2019

Member

Another security consideration is that everyone in a room will be able to see the user's poll selection/button click, so it should not be used for anything that requires secrecy.

"label": "What would you like to do?",
"options": [
{
"label": "Create Github issue",

This comment has been minimized.

Copy link
@uhoreg

uhoreg Aug 18, 2019

Member

Why do we have both label and value? Both of them seem to be intended to just be human-readable representations, and it seems like it would be a bit confusing if they're different.

This comment has been minimized.

Copy link
@turt2live

turt2live Aug 18, 2019

Author Member

value is meant to be machine readable but understandable by humans (some sort of identifier) whereas the label is the human readable string. Here though, they serve largely the same purpose.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.