Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify that /rooms/{roomId}/event/{eventId}'s 404 should be M_NOT_FOUND #2204

Merged
merged 1 commit into from Jul 31, 2019

Conversation

@anoadragon453
Copy link
Member

anoadragon453 commented Jul 31, 2019

No error code is specified for this endpoint's 404. State that it should be an M_NOT_FOUND.

@anoadragon453 anoadragon453 requested a review from turt2live Jul 31, 2019
Copy link
Member

turt2live left a comment

thanks!

@anoadragon453 anoadragon453 merged commit af60889 into master Jul 31, 2019
8 checks passed
8 checks passed
buildkite/matrix-doc Build #588 passed (1 minute, 3 seconds)
Details
ci/circleci: build-dev-scripts Your tests passed on CircleCI!
Details
ci/circleci: build-docs Your tests passed on CircleCI!
Details
ci/circleci: build-swagger Your tests passed on CircleCI!
Details
ci/circleci: check-docs Your tests passed on CircleCI!
Details
ci/circleci: validate-docs Your tests passed on CircleCI!
Details
docs Click details to preview the HTML documentation.
Details
swagger Click to preview the swagger build.
Details
@anoadragon453 anoadragon453 deleted the anoa/add_code_to_event_retrieval_endpoint branch Jul 31, 2019
anoadragon453 added a commit that referenced this pull request Jul 31, 2019
@jplatte jplatte referenced this pull request Nov 14, 2019
1 of 21 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.