Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSC2214: Joining upgraded private rooms #2214

Open
wants to merge 3 commits into
base: master
from

Conversation

@turt2live
Copy link
Member

commented Aug 2, 2019

Rendered

Related issues:

  • #1864 ("solved" by this)
  • #1941 (related by subject)
@ara4n

This comment has been minimized.

Copy link
Member

commented Aug 2, 2019

disappointing

@turt2live turt2live changed the title [WIP] MSC2214: Joining upgraded private rooms MSC2214: Joining upgraded private rooms Aug 2, 2019

@turt2live

This comment has been minimized.

Copy link
Member Author

commented Aug 2, 2019

@ara4n and now? 😇

@turt2live turt2live marked this pull request as ready for review Aug 2, 2019

@ara4n

This comment has been minimized.

Copy link
Member

commented Aug 2, 2019

much better ;)

in terms of the actual MSC: it's probably an obvious question, but: why clone over as m.room.previous_member events at all? why not make them m.room.members?

@turt2live

This comment has been minimized.

Copy link
Member Author

commented Aug 2, 2019

Because of https://github.com/matrix-org/matrix-doc/pull/2214/files#diff-3ca6ba2dd370c7a964783f11e300128eR107-R111

The TLDR is that the auth rules get difficult because we can't really do auth rules across multiple rooms yet, so it would be possible for someone to craft a room which automatically joins everyone.

Edit: and as for just spamming invites: this is also mentioned in the proposal as undesirable notifications.

@@ -0,0 +1,126 @@
# Joining upgraded private rooms

This comment has been minimized.

Copy link
@turt2live

turt2live Aug 3, 2019

Author Member

TODO: Incorporate this rationale into the proposal somewhere (and surrounding discussion)

fwiw the overarching idea is that servers just attempt to join rooms and expect it to fail, rather than have them spend a bunch of time adding if statements for suppressing notifications (which would also need to be added to every client), handling the invite differently, etc. It puts the burden of figuring out if a user can join on the server which did the upgrade (and any other resident servers after the fact), letting the client implementations need no changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.