Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for a state_key on the tombstone push rule #2223

Merged
merged 1 commit into from Aug 12, 2019

Conversation

@turt2live
Copy link
Member

turt2live commented Aug 8, 2019

This is an oversight from the proposal: #1930

This is an oversight from the proposal.
@turt2live turt2live requested a review from matrix-org/spec-core-team Aug 8, 2019
Copy link
Member

erikjohnston left a comment

This was implemented in synapse right?

@turt2live

This comment has been minimized.

Copy link
Member Author

turt2live commented Aug 12, 2019

yes, by yourself too :) matrix-org/synapse#5804

js-sdk part is here: matrix-org/matrix-js-sdk#1006

@turt2live turt2live merged commit 87590cd into master Aug 12, 2019
8 checks passed
8 checks passed
buildkite/matrix-doc Build #629 passed (57 seconds)
Details
ci/circleci: build-dev-scripts Your tests passed on CircleCI!
Details
ci/circleci: build-docs Your tests passed on CircleCI!
Details
ci/circleci: build-swagger Your tests passed on CircleCI!
Details
ci/circleci: check-docs Your tests passed on CircleCI!
Details
ci/circleci: validate-docs Your tests passed on CircleCI!
Details
docs Click details to preview the HTML documentation.
Details
swagger Click to preview the swagger build.
Details
@turt2live turt2live deleted the travis/fix-tombstone branch Aug 12, 2019
@erikjohnston

This comment has been minimized.

Copy link
Member

erikjohnston commented Aug 12, 2019

You don't seriously expect me to remember what I did 12 days ago, right?!?!!?

@turt2live

This comment has been minimized.

Copy link
Member Author

turt2live commented Aug 12, 2019

it is a long time ago, I'll give you that :p

@jplatte jplatte referenced this pull request Nov 14, 2019
1 of 21 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.