Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the action of a room key request cancellation. #2247

Merged
merged 2 commits into from Aug 26, 2019

Conversation

@poljar
Copy link
Contributor

poljar commented Aug 26, 2019

The spec states that the action of a room key request cancellation
should be "cancel_request" but every known implementation uses
"request_cancellation" instead.

This patch fixes the spec to reflect the implementations.

The spec states that the action of a room key request cancellation
should be "cancel_request" but every known implementation uses
"request_cancellation" instead.

This patch fixes the spec to reflect the implementations.
@turt2live

This comment has been minimized.

Copy link
Member

turt2live commented Aug 26, 2019

Is it possible to get a link to the implementations which do this?

@turt2live turt2live self-requested a review Aug 26, 2019
@turt2live

This comment has been minimized.

Copy link
Member

turt2live commented Aug 26, 2019

also changelog please

@turt2live

This comment has been minimized.

Copy link
Member

turt2live commented Aug 26, 2019

Just here - it's to prove that we aren't making claims that "implementation do this" without evidence.

@poljar

This comment has been minimized.

Copy link
Contributor Author

poljar commented Aug 26, 2019

Is this considered a spec clarification or a breaking change?

@turt2live

This comment has been minimized.

Copy link
Member

turt2live commented Aug 26, 2019

Clarification

Copy link
Member

turt2live left a comment

thanks!

@turt2live turt2live merged commit 808eda4 into master Aug 26, 2019
8 checks passed
8 checks passed
buildkite/matrix-doc Build #726 passed (1 minute, 17 seconds)
Details
ci/circleci: build-dev-scripts Your tests passed on CircleCI!
Details
ci/circleci: build-docs Your tests passed on CircleCI!
Details
ci/circleci: build-swagger Your tests passed on CircleCI!
Details
ci/circleci: check-docs Your tests passed on CircleCI!
Details
ci/circleci: validate-docs Your tests passed on CircleCI!
Details
docs Click details to preview the HTML documentation.
Details
swagger Click to preview the swagger build.
Details
poljar added a commit to poljar/matrix-nio that referenced this pull request Aug 27, 2019
The spec stated that a key request cancellation should have the action
"cancel_request" but riot and friends used "request_cancellation"
instead.

The spec will be changed to reflect the implementations so let us use
the "request_cancellation" action as well.

Upstream pull request: matrix-org/matrix-doc#2247
@jplatte jplatte referenced this pull request Nov 14, 2019
1 of 21 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.