Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix the action of a room key request cancellation. #2247
The spec states that the action of a room key request cancellation should be "cancel_request" but every known implementation uses "request_cancellation" instead. This patch fixes the spec to reflect the implementations.
You want references in the commit message as well or just here?
The android sdk: https://github.com/matrix-org/matrix-android-sdk/blob/903ae8a8d7c05d90a5c9888c6ae9b1e58d8d4ad7/matrix-sdk-crypto/src/main/java/org/matrix/androidsdk/crypto/rest/model/crypto/RoomKeyShare.java#L27
The spec stated that a key request cancellation should have the action "cancel_request" but riot and friends used "request_cancellation" instead. The spec will be changed to reflect the implementations so let us use the "request_cancellation" action as well. Upstream pull request: matrix-org/matrix-doc#2247