Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate the v1 IS API and replace most of it with v2 #2254

Merged
merged 5 commits into from Aug 28, 2019

Conversation

@turt2live
Copy link
Member

turt2live commented Aug 28, 2019

This is part 1 of many, as shown by #2253

It may be easier to review this commit by commit. See 'docs' status check for what this looks like in the spec.

This PR handles deprecating the v1 API and replacing relevant bits with v2 stuff. This is an intermediary step to show at the spec level that v1 is truly deprecated, but does mean the whole thing is duplicated. The next IS spec version after this one is expected to delete the v1 stuff completely.

This PR intentionally does not handle defining the auth endpoints and how all that works in an effort to keep the PRs moderately reviewable. This PR does not include the new lookup API for the same reason.

Specs part of MSC2140.

turt2live added 5 commits Aug 28, 2019
Note that ping and pubkey doesn't require auth - see MSC2140 for more information.
@turt2live turt2live requested a review from matrix-org/spec-core-team Aug 28, 2019
@turt2live turt2live referenced this pull request Aug 28, 2019
10 of 10 tasks complete
@dbkr
dbkr approved these changes Aug 28, 2019
Copy link
Member

dbkr left a comment

lgtm I think - I didn't see the terms & register stuff, is that coming separately?

Edit: as you say in the bug, yes it is

@turt2live

This comment has been minimized.

Copy link
Member Author

turt2live commented Aug 28, 2019

yup, writing it now.

@turt2live turt2live merged commit 03641d9 into master Aug 28, 2019
8 checks passed
8 checks passed
buildkite/matrix-doc Build #739 passed (1 minute)
Details
ci/circleci: build-dev-scripts Your tests passed on CircleCI!
Details
ci/circleci: build-docs Your tests passed on CircleCI!
Details
ci/circleci: build-swagger Your tests passed on CircleCI!
Details
ci/circleci: check-docs Your tests passed on CircleCI!
Details
ci/circleci: validate-docs Your tests passed on CircleCI!
Details
docs Click details to preview the HTML documentation.
Details
swagger Click to preview the swagger build.
Details
@turt2live turt2live deleted the travis/spec/is-v2 branch Aug 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.