Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spec IS terms of service #2258

Merged
merged 10 commits into from Sep 6, 2019

Conversation

@turt2live
Copy link
Member

turt2live commented Aug 29, 2019

This is part 3 of many, as shown by #2253

Based on #2255 - the actual diff is here. See 'docs' status check for what this looks like in the spec.

Specs part of MSC2140.

@turt2live turt2live referenced this pull request Aug 29, 2019
10 of 10 tasks complete
@turt2live turt2live changed the title Spec IS terms of service [WIP] Spec IS terms of service Aug 29, 2019
@turt2live turt2live force-pushed the travis/spec/is-terms branch 2 times, most recently from faedc92 to ec12f4d Sep 3, 2019
turt2live added 3 commits Sep 3, 2019
Part of MSC2140

Convert status codes to strings if there is a string status code. Fixes a build error when we mix 4xx and 403 in the same definition. We also have to correct stringified numbers to pass the build.
@turt2live turt2live force-pushed the travis/spec/is-terms branch from c85aa4c to afd5018 Sep 3, 2019
@turt2live turt2live changed the title [WIP] Spec IS terms of service Spec IS terms of service Sep 3, 2019
@turt2live turt2live marked this pull request as ready for review Sep 3, 2019
@turt2live turt2live requested a review from matrix-org/spec-core-team Sep 3, 2019
@dbkr
dbkr approved these changes Sep 6, 2019
@jryans
jryans approved these changes Sep 6, 2019
@turt2live turt2live merged commit a24bcc2 into master Sep 6, 2019
8 checks passed
8 checks passed
buildkite/matrix-doc Build #805 passed (59 seconds)
Details
ci/circleci: build-dev-scripts Your tests passed on CircleCI!
Details
ci/circleci: build-docs Your tests passed on CircleCI!
Details
ci/circleci: build-swagger Your tests passed on CircleCI!
Details
ci/circleci: check-docs Your tests passed on CircleCI!
Details
ci/circleci: validate-docs Your tests passed on CircleCI!
Details
docs Click details to preview the HTML documentation.
Details
swagger Click to preview the swagger build.
Details
@turt2live turt2live deleted the travis/spec/is-terms branch Sep 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.