Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spec client-server IS unbind API #2282

Merged
merged 4 commits into from Sep 10, 2019

Conversation

@turt2live
Copy link
Member

turt2live commented Sep 4, 2019

This is part 5 of many, as shown by #2253

Based on #2255 - the actual diff is here. See 'docs' status check for what this looks like in the spec.

Specs part of MSC2140.

Note: this modifies the endpoint in MSC2140 to be more in line with the remainder of the proposal.

turt2live added 2 commits Sep 4, 2019
As per [MSC2140](#2140)

Note: this modifies the endpoint in MSC2140 to be more in line with the remainder of the proposal.
@turt2live

This comment has been minimized.

Copy link
Member Author

turt2live commented Sep 5, 2019

matrix-org/synapse#5980 shows that this spec appears to be the correct way to do things.

@turt2live turt2live marked this pull request as ready for review Sep 5, 2019
@turt2live turt2live removed the blocked label Sep 5, 2019
@turt2live turt2live requested a review from matrix-org/spec-core-team Sep 5, 2019
summary: Removes a user's third party identifier from an identity server.
description: |-
Removes a user's third party identifier from the provided identity server.
This should not cause an unbind from the homeserver (as ``/3pid/delete``

This comment has been minimized.

Copy link
@dbkr

dbkr Sep 6, 2019

Member

An 'unbind from the homeserver' isn't really a defined thing: 'binding' is the 3pid -> mxid mapping on the IS. I would just say maybe, "Removes a user's third party identifier from the provided identity server without removing it from the homeserver[...]".

@turt2live turt2live requested a review from dbkr Sep 6, 2019
@dbkr
dbkr approved these changes Sep 10, 2019
@turt2live turt2live merged commit 7a391bf into master Sep 10, 2019
8 checks passed
8 checks passed
buildkite/matrix-doc Build #840 passed (1 minute, 16 seconds)
Details
ci/circleci: build-dev-scripts Your tests passed on CircleCI!
Details
ci/circleci: build-docs Your tests passed on CircleCI!
Details
ci/circleci: build-swagger Your tests passed on CircleCI!
Details
ci/circleci: check-docs Your tests passed on CircleCI!
Details
ci/circleci: validate-docs Your tests passed on CircleCI!
Details
docs Click details to preview the HTML documentation.
Details
swagger Click to preview the swagger build.
Details
@turt2live turt2live deleted the travis/spec/is-unbind branch Sep 10, 2019
@jplatte jplatte referenced this pull request Nov 14, 2019
1 of 21 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.