Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spec the v2 lookup API #2287

Merged
merged 3 commits into from Sep 16, 2019

Conversation

@turt2live
Copy link
Member

turt2live commented Sep 10, 2019

Spec for MSC2134
See #2253

Spec for [MSC2134](#2134)
@turt2live turt2live referenced this pull request Sep 10, 2019
10 of 10 tasks complete
@turt2live turt2live requested a review from matrix-org/spec-core-team Sep 10, 2019
Copy link
Member

anoadragon453 left a comment

Awesome job boiling down the points to make them easy to read and understand, and I believe you covered everything the MSC set out to. Some questions below.

api/identity/v2_lookup.yaml Show resolved Hide resolved
api/identity/v2_lookup.yaml Show resolved Hide resolved
specification/identity_service_api.rst Show resolved Hide resolved
specification/identity_service_api.rst Show resolved Hide resolved
@turt2live turt2live requested a review from anoadragon453 Sep 10, 2019
@turt2live

This comment has been minimized.

Copy link
Member Author

turt2live commented Sep 13, 2019

Copy link
Member

anoadragon453 left a comment

LGTM!

@turt2live turt2live merged commit 2c88f02 into master Sep 16, 2019
8 checks passed
8 checks passed
buildkite/matrix-doc Build #847 passed (1 minute, 4 seconds)
Details
ci/circleci: build-dev-scripts Your tests passed on CircleCI!
Details
ci/circleci: build-docs Your tests passed on CircleCI!
Details
ci/circleci: build-swagger Your tests passed on CircleCI!
Details
ci/circleci: check-docs Your tests passed on CircleCI!
Details
ci/circleci: validate-docs Your tests passed on CircleCI!
Details
docs Click details to preview the HTML documentation.
Details
swagger Click to preview the swagger build.
Details
@turt2live turt2live deleted the travis/spec/lookup-v2 branch Sep 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.