Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSC2300: /ping endpoint #2300

Open
wants to merge 1 commit into
base: master
from

Conversation

@ara4n
Copy link
Member

commented Sep 23, 2019

Currently there is no well-defined way for clients to determine whether their server is still alive and well.
Riot/Web fudges this by calling /versions, but this is an abuse (especially if & when /versions becomes a richer endpoint).
Enter /ping instead.

Rendered

@ara4n ara4n added the proposal label Sep 23, 2019
@ara4n

This comment has been minimized.

Copy link
Member Author

commented Sep 23, 2019

#2301 is an example of why we shouldn't be using /versions as a ping endpoint.


## Proposal

Currently there is no well-defined way for clients to determine whether their server is still alive and well.

This comment has been minimized.

Copy link
@turt2live

turt2live Sep 24, 2019

Member

why can't they check /sync or other errors? Do we really need a ping endpoint given HTTP has very well-defined errors?

Riot only uses /versions because it got an error on /sync, which it feels is a server problem and therefore tries to reinitialize itself. Hitting /versions on loop is one way of doing this and is a lighter endpoint if there are server performance problems. Theory is, I believe, that when the server starts throwing errors at you it is likely being updated or has its config changed: if it suddenly supports r0.6 then why not use that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.