Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify that submit_url is without authentication #2341

Merged
merged 2 commits into from Nov 5, 2019

Conversation

@turt2live
Copy link
Member

turt2live commented Nov 4, 2019

The request is authorized by its parameters, not by an additional access token.

Fixes #2298

The request is authorized by its parameters, not by an additional access token.

Fixes #2298
@turt2live turt2live requested a review from matrix-org/spec-core-team Nov 4, 2019
@KitsuneRal

This comment has been minimized.

Copy link
Member

KitsuneRal commented Nov 5, 2019

That seems to be inconsistent with the v2 IS endpoint that still wants an access_token (see

)?

@turt2live

This comment has been minimized.

Copy link
Member Author

turt2live commented Nov 5, 2019

The parameters are the same, not the same endpoint. In Synapse it's something like /_matrix/client/unstable/add_threepid/<type>/bind (from memory).

@dbkr
dbkr approved these changes Nov 5, 2019
@turt2live turt2live merged commit ef957b9 into master Nov 5, 2019
8 checks passed
8 checks passed
buildkite/matrix-doc Build #992 passed (1 minute, 14 seconds)
Details
ci/circleci: build-dev-scripts Your tests passed on CircleCI!
Details
ci/circleci: build-docs Your tests passed on CircleCI!
Details
ci/circleci: build-swagger Your tests passed on CircleCI!
Details
ci/circleci: check-docs Your tests passed on CircleCI!
Details
ci/circleci: validate-docs Your tests passed on CircleCI!
Details
docs Click details to preview the HTML documentation.
Details
swagger Click to preview the swagger build.
Details
@turt2live turt2live deleted the travis/spec/fix-2298 branch Nov 5, 2019
@jplatte jplatte referenced this pull request Nov 9, 2019
1 of 21 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.