Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSC2376: Disable URL Previews #2376

Open
wants to merge 6 commits into
base: master
from

Conversation

@Sorunome
Copy link
Contributor

Sorunome commented Dec 3, 2019

Rendered

This MSC provides an alternative method to MSC2385

Signed-off-by: Sorunome mail@sorunome.de

Copy link
Member

anoadragon453 left a comment

Some wording things. Functionally this MSC looks good.

proposals/2376-no-url-previews.md Outdated Show resolved Hide resolved
proposals/2376-no-url-previews.md Outdated Show resolved Hide resolved
proposals/2376-no-url-previews.md Outdated Show resolved Hide resolved
proposals/2376-no-url-previews.md Outdated Show resolved Hide resolved
proposals/2376-no-url-previews.md Outdated Show resolved Hide resolved
proposals/2376-no-url-previews.md Outdated Show resolved Hide resolved
proposals/2376-no-url-previews.md Outdated Show resolved Hide resolved
Copy link
Member

KitsuneRal left a comment

I'm not quite happy with HTML customisation approach - see my comments below. The described alternative looks much more reasonable to me, as long as we enforce that URLs in the no-preview list match those in the body.

proposals/2376-no-url-previews.md Outdated Show resolved Hide resolved
proposals/2376-no-url-previews.md Outdated Show resolved Hide resolved
proposals/2376-no-url-previews.md Outdated Show resolved Hide resolved
@turt2live turt2live self-requested a review Dec 3, 2019
Copy link
Member

uhoreg left a comment

Looks pretty good.

proposals/2376-no-url-previews.md Outdated Show resolved Hide resolved
proposals/2376-no-url-previews.md Outdated Show resolved Hide resolved
Sorunome added 3 commits Dec 3, 2019
@Sorunome Sorunome force-pushed the Sorunome:soru/no-url-previews branch from 1b987de to 9211a54 Dec 3, 2019
Sorunome added 2 commits Dec 3, 2019
@Sorunome

This comment has been minimized.

Copy link
Contributor Author

Sorunome commented Dec 8, 2019

I'm not quite happy with HTML customisation approach - see my comments below. The described alternative looks much more reasonable to me, as long as we enforce that URLs in the no-preview list match those in the body.

Should soru make a competing MSC to this one with that other proposal?

@KitsuneRal

This comment has been minimized.

Copy link
Member

KitsuneRal commented Dec 8, 2019

I'm not quite happy with HTML customisation approach - see my comments below. The described alternative looks much more reasonable to me, as long as we enforce that URLs in the no-preview list match those in the body.

Should soru make a competing MSC to this one with that other proposal?

I'd appreciate that.

@Sorunome

This comment has been minimized.

Copy link
Contributor Author

Sorunome commented Dec 8, 2019

I'm not quite happy with HTML customisation approach - see my comments below. The described alternative looks much more reasonable to me, as long as we enforce that URLs in the no-preview list match those in the body.

Should soru make a competing MSC to this one with that other proposal?

I'd appreciate that.

Done! #2385

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.