Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSC2380: Matrix Media Information API #2380

Open
wants to merge 2 commits into
base: master
from

Conversation

@anoadragon453
Copy link
Member

anoadragon453 commented Dec 5, 2019

Rendered

Author: @turt2live

Fixes: #703

@anoadragon453 anoadragon453 changed the title Matrix Media Information API MSC2380: Matrix Media Information API Dec 5, 2019
content. Given the content types are optional, clients may not rely on the
information being present anyways.

This would also be yet another HTTP call that clients would have to perform.

This comment has been minimized.

Copy link
@KitsuneRal

KitsuneRal Dec 8, 2019

Member

It would be great if data model in this MSC be aligned with that used in the related msgtypes (m.file etc.): e.g., the current convention uses w and h instead of width and height. Alternatively, this MSC could be put into relationship to extensible events (making it a much longer story) because the current convention, admittedly, is suboptimal.

the content repository cannot identify the type, it must return
application/octet-stream.

The size is just the size in bytes.

This comment has been minimized.

Copy link
@Half-Shot

Half-Shot Dec 8, 2019

Contributor
Suggested change
The size is just the size in bytes.
The `size` is just the size in bytes.
}
```

The content repository must attempt to identify the content independently of

This comment has been minimized.

Copy link
@Sorunome

Sorunome Jan 13, 2020

Contributor

This is probably out-of-scope for this MSC but....why do clients specify the content type at all, then? Wouldn't it be better if the server always determines it and adds it to the event, then? That way people receiving the image events could also be sure that the content type is accurate.

This comment has been minimized.

Copy link
@Sorunome

Sorunome Jan 13, 2020

Contributor

like, it might make more sense for the server to replace the "info" blob rather than the client to specify it.

This comment has been minimized.

Copy link
@turt2live

turt2live Jan 13, 2020

Member

This recommendation is actually a terrible idea because encrypted attachments are blobs.

This comment has been minimized.

Copy link
@Sorunome

Sorunome Jan 14, 2020

Contributor

Right, forgot for a moment encryption exists 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.