New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spell out the state algorithm for createRoom #362

Merged
merged 1 commit into from Jul 18, 2016

Conversation

Projects
None yet
2 participants
@richvdh
Member

richvdh commented Jul 18, 2016

Fixes https://matrix.org/jira/browse/SPEC-429.

Synapse currently follows the specified ordering, but does not give the
specified error when the state is invalid (instead it creates the room anyway
but gives a 403 M_FORBIDDEN). Still, I don't think that should be a real
problem for any real clients, and nothing would break if we changed this in
synapse, so it might as well go in the spec anyway.

Spell out the state algorithm for createRoom
Fixes https://matrix.org/jira/browse/SPEC-429.

Synapse currently follows the specified ordering, but does *not* give the
specified error when the state is invalid (instead it creates the room anyway
but gives a 403 M_FORBIDDEN). Still, I don't think that should be a real
problem for any real clients, and nothing would break if we changed this in
synapse, so it might as well go in the spec anyway.
@erikjohnston

This comment has been minimized.

Member

erikjohnston commented Jul 18, 2016

LGTM

@richvdh

This comment has been minimized.

Member

richvdh commented Jul 18, 2016

tyvm

@richvdh richvdh merged commit 66bfd04 into master Jul 18, 2016

1 check passed

default Build finished.
Details

@richvdh richvdh deleted the rav/create_room_behaviour branch Aug 15, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment