New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the display name rule an override rule #373

Merged
merged 3 commits into from Aug 17, 2016

Conversation

Projects
None yet
2 participants
@dbkr
Member

dbkr commented Aug 15, 2016

No description provided.

dbkr added a commit to matrix-org/synapse that referenced this pull request Aug 15, 2016

@dbkr dbkr referenced this pull request Aug 15, 2016

Merged

Move display name rule #1011

@dbkr

This comment has been minimized.

Member

dbkr commented Aug 15, 2016

Hold on, this will affect more things than I thought.

@dbkr dbkr assigned dbkr and unassigned richvdh Aug 15, 2016

@dbkr

This comment has been minimized.

Member

dbkr commented Aug 16, 2016

OK, this is fine: all current clients work whatever the priority class of this rule is. See matrix-org/synapse#1011 for the synapse changes.

@dbkr dbkr assigned richvdh and unassigned dbkr Aug 16, 2016

@richvdh

This comment has been minimized.

Member

richvdh commented Aug 16, 2016

needs changelog entry, probably with text explaining why we think we can make breaking changes.

@richvdh richvdh assigned dbkr and unassigned richvdh Aug 16, 2016

@dbkr

This comment has been minimized.

Member

dbkr commented Aug 16, 2016

done

@dbkr dbkr assigned richvdh and unassigned dbkr Aug 16, 2016

@richvdh

This comment has been minimized.

@richvdh

This comment has been minimized.

Member

richvdh commented Aug 17, 2016

(lgtm otherwise)

@richvdh richvdh assigned dbkr and unassigned richvdh Aug 17, 2016

@dbkr dbkr merged commit fd888fc into master Aug 17, 2016

2 checks passed

Docs (Commit) Build #1764 succeeded in 30 sec
Details
Docs (Merged PR) Build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment