New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

window.postmessage for Interactive Auth fallback #398

Merged
merged 2 commits into from Oct 10, 2016

Conversation

Projects
None yet
2 participants
@richvdh
Member

richvdh commented Oct 6, 2016

Require that User-Interactive auth fallback pages call window.postMessage to notify apps of completion.

window.postmessage for Interactive Auth fallback
Require that User-Interactive auth fallback pages call
`window.postMessage` to notify apps of completion.
@@ -562,12 +567,13 @@ the type and session, if provided:
.. code:: json
{
"type": "m.login.dummy"
"type": "m.login.dummy",
"session": "<session ID>"

This comment has been minimized.

@dbkr

dbkr Oct 7, 2016

Member

This could be slightly confusing since there's no reason you'd ever submit a session with dummy auth

This comment has been minimized.

@richvdh

richvdh Oct 7, 2016

Member

we agreed to leave this as-is for consistency with the other login types. The logic is "if you get a session id, send it back", not "if you get a session id, send it back, unless you're doing dummy auth, in which case you don't need to bother".

var popupWindow;
var eventListener = function(ev) {
if (ev.data !== "authDone" ) {

This comment has been minimized.

@dbkr

dbkr Oct 7, 2016

Member

You probably ought to check the domain of the event sender here.

This comment has been minimized.

@richvdh

@dbkr dbkr assigned richvdh and unassigned dbkr Oct 7, 2016

@richvdh

This comment has been minimized.

Member

richvdh commented Oct 7, 2016

ptal?

@dbkr

dbkr approved these changes Oct 10, 2016

@dbkr dbkr merged commit 8cd9221 into master Oct 10, 2016

2 checks passed

Docs (Commit) Build #1867 succeeded in 35 sec
Details
Docs (Merged PR) Build finished.
Details

@richvdh richvdh deleted the rav/uia_fallback_postmessage branch Oct 12, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment