window.postmessage for Interactive Auth fallback #398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Require that User-Interactive auth fallback pages call `window.postMessage` to notify apps of completion.
dbkr
requested changes
Oct 7, 2016
| @@ -562,12 +567,13 @@ the type and session, if provided: | |||
| .. code:: json | |||
|
|
|||
| { | |||
| "type": "m.login.dummy" | |||
| "type": "m.login.dummy", | |||
| "session": "<session ID>" | |||
There was a problem hiding this comment.
This could be slightly confusing since there's no reason you'd ever submit a session with dummy auth
There was a problem hiding this comment.
we agreed to leave this as-is for consistency with the other login types. The logic is "if you get a session id, send it back", not "if you get a session id, send it back, unless you're doing dummy auth, in which case you don't need to bother".
| var popupWindow; | ||
|
|
||
| var eventListener = function(ev) { | ||
| if (ev.data !== "authDone" ) { |
There was a problem hiding this comment.
You probably ought to check the domain of the event sender here.
|
ptal? |
dbkr
approved these changes
Oct 10, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Require that User-Interactive auth fallback pages call
window.postMessageto notify apps of completion.