New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make m.notice description use stricter language #750

Merged
merged 2 commits into from Nov 30, 2016

Conversation

Projects
None yet
5 participants
@kyrias
Contributor

kyrias commented Nov 29, 2016

No description provided.

@matrixbot

This comment has been minimized.

Member

matrixbot commented Nov 29, 2016

Can one of the admins verify this patch?

@dbkr

This comment has been minimized.

Member

dbkr commented Nov 29, 2016

Seems reasonable, although for consistency we probably ought to stick with single-space-after-full-stop. @richvdh wdyt?

@kyrias

This comment has been minimized.

Contributor

kyrias commented Nov 29, 2016

Ah, sorry, I double space out of habit. Doesn't make a difference for the generated HTML of course, but I'll push a fixed version if the rest seems okay.

@uhoreg

This comment has been minimized.

Member

uhoreg commented Nov 29, 2016

"visually distinct" doesn't make sense for speech- or Braille-based UIs. Perhaps the suggested wording could be altered to something along the lines of "... clients should present m.notice messages to users in a distinct manner..."?

@kyrias

This comment has been minimized.

Contributor

kyrias commented Nov 29, 2016

Thank you @uhoreg, updated with your suggestion.

Make m.notice description use stricter language
Signed-off-by: Johannes Löthberg <johannes@kyriasis.com>
@richvdh

This comment has been minimized.

Member

richvdh commented Nov 30, 2016

matrixbot: test this please

@richvdh

This comment has been minimized.

Member

richvdh commented Nov 30, 2016

lgtm.

A comment for the changelog (https://github.com/matrix-org/matrix-doc/blob/master/changelogs/client_server.rst) would be appreciated.

Add m.notice description rephrasing to changelog
Signed-off-by: Johannes Löthberg <johannes@kyriasis.com>
@kyrias

This comment has been minimized.

Contributor

kyrias commented Nov 30, 2016

Added the comment

@richvdh

This comment has been minimized.

Member

richvdh commented Nov 30, 2016

tyvm!

@richvdh richvdh merged commit 3265a9d into matrix-org:master Nov 30, 2016

@kyrias kyrias deleted the kyrias:notice-language branch Nov 30, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment