New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Room member #950

Merged
merged 8 commits into from Jul 14, 2017

Conversation

Projects
None yet
2 participants
@babolivier
Member

babolivier commented Jul 13, 2017

  • Fixed an incorrect membership attribute in an example (which was contradictory with the memberships list above it)
  • Added a precision on the membership attribute of the m.room.member event sent upon a profile update

babolivier added some commits Jul 13, 2017

@richvdh

This comment has been minimized.

Member

richvdh commented Jul 14, 2017

Thanks!

There are actually two copies of this example: See also https://github.com/matrix-org/matrix-doc/blob/34cdd4e36850347c057bcfb1d5db4904c8ef18cd/event-schemas/examples/m.room.member. Perhaps you'd like to either fix or delete that one while you are there?

Also: please could you add a note to https://github.com/matrix-org/matrix-doc/blob/34cdd4e36850347c057bcfb1d5db4904c8ef18cd/changelogs/client_server.rst under 'spec clarifications'?

@babolivier

This comment has been minimized.

Member

babolivier commented Jul 14, 2017

There are actually two copies of this example: See also https://github.com/matrix-org/matrix-doc/blob/34cdd4e36850347c057bcfb1d5db4904c8ef18cd/event-schemas/examples/m.room.member. Perhaps you'd like to either fix or delete that one while you are there?

Sure, I didn't notice it, on it.

Also: please could you add a note to https://github.com/matrix-org/matrix-doc/blob/34cdd4e36850347c057bcfb1d5db4904c8ef18cd/changelogs/client_server.rst under 'spec clarifications'?

Sure, I wasn't aware of this document. Mabe adding a mention to it in https://github.com/matrix-org/matrix-doc/blob/master/CONTRIBUTING.rst would be a good idea?

babolivier added some commits Jul 14, 2017

@babolivier

This comment has been minimized.

Member

babolivier commented Jul 14, 2017

In the latests commits, I also changed the example for /rooms/{roomId}/state/{eventType}/{stateKey} to use an event that actually use a state key.

@richvdh richvdh merged commit 750d980 into master Jul 14, 2017

2 checks passed

Docs (Commit) Build #2072 succeeded in 36 sec
Details
Docs (Merged PR) Build finished.
Details

@babolivier babolivier deleted the babolivier/fix-room-member branch Jul 27, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment