New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add remote invites and third-party invites to the federation spec #997

Merged
merged 8 commits into from Sep 15, 2017

Conversation

Projects
None yet
2 participants
@babolivier
Member

babolivier commented Sep 14, 2017

This PR:

  • Adds a "Inviting to a room" section to the federation spec explaining how to send a m.room.member invite event to a remote server
  • Adds a "Third-party invites" section to the federation spec explaining the process and logic for handling third-party invites
  • Updates the body of the POST .../_matrix/federation/v1/3pid/onbind request specified in the identity service spec

Fixes #989
Fixes #991
Fixes #992

babolivier added some commits Sep 13, 2017

@babolivier babolivier requested a review from NegativeMjark Sep 15, 2017

When a homeserver receives a ``m.room.member`` invite event for a room it's in
with a ``third_party_invite`` object, it must verify that the association between
the third-party identifier initially invited to the room and the Matrix ID that
claim to be bound to it has been verified without having to rely on a third-party

This comment has been minimized.

@NegativeMjark

NegativeMjark Sep 15, 2017

Contributor

"claims"

This comment has been minimized.

@babolivier
Inviting to a room
------------------
When a user wishes to invite an other user to a local room and this other user

This comment has been minimized.

@NegativeMjark

NegativeMjark Sep 15, 2017

Contributor

I would probably write this as "and the other user" rather than "and this other user".

This comment has been minimized.

@babolivier
@NegativeMjark

LGTM

@babolivier babolivier merged commit 19579c7 into master Sep 15, 2017

1 check passed

Docs (Merged PR) Build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment