extend method redactEvent with reason #1462
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turt2live
requested changes
Sep 9, 2020
There was a problem hiding this comment.
Thanks for taking on the fix! We should find a way to get this into the existing function to avoid building out infinite problems. My suggestion would be to support multiple call signatures by switching on the callback argument's type.
We also need sign-off on these changes.
|
Alright, that we can do :) Thanks! |
orangecms
changed the title
turt2live
requested changes
Sep 18, 2020
orangecms
force-pushed
the
develop
branch
3 times, most recently
from
1142c77 to
aad7484
Compare
Signed-off-by: Daniel Maslowski <info@orangecms.org>
turt2live
approved these changes
Sep 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements passing a reason for the redaction as per https://matrix.org/docs/spec/client_server/r0.6.1#id254
Disclaimer: @fridtjof, @Mythozz and @badgateway666 made me do this :p