Fix uploadContent for node.js #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9e89e71 broke uploadContent, making it set 'json=true' on the request, so that we would try to turn raw content into JSON. It also misguidedly set a client-side timeout of 30s. Fix that, and add some tests to check uploadContent works. In mock-request: distinguish between an expectation (ExpectedRequest) and an actual request (Request). Add support for checking the headers, and the request options in general, to Request.
richvdh
force-pushed
the
rav/fix_upload
branch
from
9a48bc8
to
a3d86c0
Compare
ara4n
approved these changes
Oct 8, 2016
|
I've tried to address the bifurcated API in #230. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
9e89e71 broke uploadContent, making it set 'json=true' on the request, so that we would try to turn raw content into JSON. It also misguidedly set a client-side timeout of 30s.
Fix that, and add some tests to check
uploadContentworks.In mock-request: distinguish between an expectation (
ExpectedRequest) and an actual request (Request). Add support for checking the headers, and the request options in general, toRequest.