Add MatrixClient.doesServerSupportLogoutDevices() for MSC2457 #2297
Conversation
hughns
added
the
T-Enhancement
Codecov Report
@@ Coverage Diff @@
## develop #2297 +/- ##
===========================================
+ Coverage 59.71% 59.73% +0.01%
===========================================
Files 91 91
Lines 16439 16442 +3
Branches 3794 3796 +2
===========================================
+ Hits 9817 9822 +5
+ Misses 6622 6620 -2
|
|
out of interest, why are we adding more of these |
|
Multiple places call it, where you put the utility function might as well be js-sdk for re-use |
|
it's quite questionable as a utility function even still, honestly. These functions make sense for unstable features, not for released things. The check is also a bit awkward because it doesn't account for the fact that a server doesn't need to implement r0.6.1 but can implement v1.1 or v1.2. This isn't a problem unique to this change though, so won't require it being fixed here. |
Agreed, even more reason for them to happen in js-sdk where they can be fixed holistically. Though would be nice if they could be extracted from the MatrixClient into a separate Features class or similar to make this class less huge |
Exactly + ... What I actually wanted to check is whether version However, I didn't find such existing logic and so decided it would be better to leave the "flawed" version checking logic alongside the other "flawed" logic rather than strewn across the codebase (and without bloating my oneliner PR). |
|
I would still argue that a purpose-built |
|
Haha. Like great minds adrift in the night. |
* Add MatrixClient.doesServerSupportLogoutDevices() for MSC2457 ([\matrix-org#2297](matrix-org#2297)). * Live location sharing - expose room liveBeaconIds ([\matrix-org#2296](matrix-org#2296)). * Support for MSC2457 logout_devices param for setPassword() ([\matrix-org#2285](matrix-org#2285)). * Stabilise token authenticated registration support ([\matrix-org#2181](matrix-org#2181)). Contributed by @govynnus. * Live location sharing - Aggregate beacon locations on beacons ([\matrix-org#2268](matrix-org#2268)). * Prevent duplicated re-emitter setups in event-mapper ([\matrix-org#2293](matrix-org#2293)). * Make self membership less prone to races ([\matrix-org#2277](matrix-org#2277)). Fixes element-hq/element-web#21661.
Here's what your changelog entry will look like:
✨ Features