Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stub out the rust crypto implementation for browserify #3187

Merged
merged 5 commits into from Mar 3, 2023

Conversation

richvdh
Copy link
Member

@richvdh richvdh commented Mar 2, 2023

Fixes #3182.

Even this took me an annoyingly long time to figure out. We really need to figure out if browserify is important to us.


This change is marked as an internal change (Task), so will not be included in the changelog.

@richvdh richvdh requested review from a team as code owners March 2, 2023 19:06
@richvdh
Copy link
Member Author

richvdh commented Mar 2, 2023

gah, this breaks webpack as well

@richvdh richvdh marked this pull request as draft March 2, 2023 19:15
package.json Outdated Show resolved Hide resolved
@richvdh richvdh added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label Mar 2, 2023
Comment on lines +156 to +163
"babelify",
{
"sourceMaps": "inline",
"presets": [
"@babel/preset-env",
"@babel/preset-typescript"
]
}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

moving this here wasn't a requirement, but the commandline was getting increasingly unwieldy.

Copy link
Member

@t3chguy t3chguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me, thanks!!

src/rust-crypto/browserify-index.ts Outdated Show resolved Hide resolved
@t3chguy
Copy link
Member

t3chguy commented Mar 3, 2023

(Feel free to bypass sonar here)

Co-authored-by: Michael Telatynski <7t3chguy@gmail.com>
@richvdh richvdh merged commit 585ce07 into develop Mar 3, 2023
13 of 18 checks passed
@richvdh richvdh deleted the rav/browserify_weightwatchers branch March 3, 2023 10:18
@github-actions github-actions bot deployed to PR Documentation Preview March 3, 2023 10:20 Active
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

browser-matrix.min.js file size became 4x larger, causing negative impact on web app startup time
2 participants