New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stub out the rust crypto implementation for browserify #3187
Conversation
Putting all this stuff on the commandline is unweildy.
gah, this breaks webpack as well |
"babelify", | ||
{ | ||
"sourceMaps": "inline", | ||
"presets": [ | ||
"@babel/preset-env", | ||
"@babel/preset-typescript" | ||
] | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
moving this here wasn't a requirement, but the commandline was getting increasingly unwieldy.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me, thanks!!
(Feel free to bypass sonar here) |
Co-authored-by: Michael Telatynski <7t3chguy@gmail.com>
Fixes #3182.
Even this took me an annoyingly long time to figure out. We really need to figure out if browserify is important to us.
This change is marked as an internal change (Task), so will not be included in the changelog.