[E2E] Megolm outbound sessions #240
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
Contributor
Author
|
Pointer to a discussion about an old version of |
non-Jedi
reviewed
Aug 2, 2018
matrix_client/room.py
Outdated
| is unencrypted. | ||
| """ | ||
| if not self.client._encryption or not self.encrypted: | ||
| raise RuntimeError |
Collaborator
There was a problem hiding this comment.
Is RuntimeError the best exception to be raised here (it might be, but I've never used it before, so I don't know when it'd be appropriate)? My approach would have been to define a new MatrixNotEncrypted exception or something along those lines.
Contributor
Author
There was a problem hiding this comment.
You're right, I've been lazy (and wasn't sure if it was worth a new exception). Note that the doc says about RuntimeError "Raised when an error is detected that doesn’t fall in any of the other categories.", so it was probably the best built-in exception :)
Use a thread to allow downloading the keys in a non-blocking way. Implement sort of a queue of users who need updating, which should be efficient (request is fired as soon as possible with as much data as possible) and avoid races (we always have only one download in progress).
This has the effect of tracking the device lists of users proactively.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's the part about sending encrypted group messages, both the crypto bits and the integration into the client.
Signed-off-by: Valentin Deniaud <valentin.deniaud@inpt.fr>