[E2E] Various improvements #265
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zil0
force-pushed
the
fixups
branch
3 times, most recently
from
5c3fed1
to
4ff57d4
Compare
Use a thread to allow downloading the keys in a non-blocking way. Implement sort of a queue of users who need updating, which should be efficient (request is fired as soon as possible with as much data as possible) and avoid races (we always have only one download in progress).
This has the effect of tracking the device lists of users proactively.
Since device tracking is done in a separate thread, we need to be careful not to use the same connection object between threads (in fact the problem existed since the first persistence commit when using MatrixClient.start_listener_thread).
Nicer sqlite practices and better docstrings.
A side-effect is that this removes the ability to store E2E data for different devices of the same user in the DB. It shouldn't be much of a problem as it is easy to use multiple DB files for different instances of MatrixClient. Signed-off-by: Valentin Deniaud <valentin.deniaud@inpt.fr>
Make those tests more maintanable by getting rid of unwanted side effects and useless cleanups by using pytest.fixture, along with some readability improvements.
Encryption shouldn't be supported on limited cache_level. Even if it may work a bit, it causes a lot of data to be cached.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Smallish PR adding general improvements (no new functionality).
Signed-off-by: Valentin Deniaud <valentin.deniaud@inpt.fr>