matrix_client: Allow dynamic removal of listeners #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding listeners is an action that cannot be reversed, while many users need the ability to dynamically change whether they want to listen or not. This patch assigns each listener with a unique id which allows users to use it as a later reference for the same listener in case they want to remove it. This infrastructure can also be used in future commits to allow modifying of listeners on-the-go. Signed-off-by: Gal Pressman <galpressman@gmail.com>
|
Can one of the admins verify this patch? |
|
Just to clarify, this does not break backwards compatibility. |
|
Ok to test |
|
We can also do it the "stupid" (more simple) way of providing the callback pointer as a parameter and remove it from the list, what do you like more? |
|
This solution seems fine to me actually. In the future, I'd like to condense the code a little because I just feel there is a tad too much repetition, but for now this will do. |
Half-Shot
approved these changes
Jan 18, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding listeners is an action that cannot be reversed, while many users
need the ability to dynamically change whether they want to listen or not.
This patch assigns each listener with a unique id which allows users to
use it as a later reference for the same listener in case they want to
remove it.
This infrastructure can also be used in future commits to allow modifying
of listeners on-the-go.
Signed-off-by: Gal Pressman galpressman@gmail.com