From cbfe5de4278de03659784e6080fe305073eea36b Mon Sep 17 00:00:00 2001 From: Alun Turner Date: Fri, 12 May 2023 08:50:07 +0100 Subject: [PATCH] fix strict null error --- .../rooms/wysiwyg_composer/hooks/useSuggestion.ts | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/src/components/views/rooms/wysiwyg_composer/hooks/useSuggestion.ts b/src/components/views/rooms/wysiwyg_composer/hooks/useSuggestion.ts index 7cb460e1a9c..3e514f9e27d 100644 --- a/src/components/views/rooms/wysiwyg_composer/hooks/useSuggestion.ts +++ b/src/components/views/rooms/wysiwyg_composer/hooks/useSuggestion.ts @@ -17,7 +17,7 @@ limitations under the License. import { Attributes, MappedSuggestion } from "@matrix-org/matrix-wysiwyg"; import { SyntheticEvent, useState } from "react"; -import { isNotUndefined } from "../../../../../Typeguards"; +import { isNotNull, isNotUndefined } from "../../../../../Typeguards"; /** * Information about the current state of the `useSuggestion` hook. @@ -171,10 +171,12 @@ export function processMention( // now add the leading text node, link element and trailing text node before removing the node we are replacing const parentNode = node.parentNode; - parentNode.insertBefore(leadingTextNode, node); - parentNode.insertBefore(linkElement, node); - parentNode.insertBefore(trailingTextNode, node); - parentNode.removeChild(node); + if (isNotNull(parentNode)) { + parentNode.insertBefore(leadingTextNode, node); + parentNode.insertBefore(linkElement, node); + parentNode.insertBefore(trailingTextNode, node); + parentNode.removeChild(node); + } // move the selection to the trailing text node document.getSelection()?.setBaseAndExtent(trailingTextNode, 1, trailingTextNode, 1);