From d5ce8f2164e6b314192db3e15b6377edf49a43df Mon Sep 17 00:00:00 2001 From: Andy Balaam Date: Thu, 19 Oct 2023 17:45:17 +0100 Subject: [PATCH] Enable test fixed by https://github.com/matrix-org/matrix-js-sdk/pull/3800 (#11764) * Update comments on flaky tests * Enable a test that is fixed by matrix-js-sdk#3800 --- cypress/e2e/read-receipts/redactions.spec.ts | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/cypress/e2e/read-receipts/redactions.spec.ts b/cypress/e2e/read-receipts/redactions.spec.ts index 621e624c70e9..432cf3483f3b 100644 --- a/cypress/e2e/read-receipts/redactions.spec.ts +++ b/cypress/e2e/read-receipts/redactions.spec.ts @@ -266,7 +266,7 @@ describe("Read receipts", () => { // Then the room is still read assertRead(room2); }); - // Flakes because sometimes the unread count stays at 2 + // XXX: fails because it flakes because sometimes the unread count stays at 2 it.skip("Reacting to a redacted message leaves the room read", () => { // Given a redacted message exists goTo(room1); @@ -504,7 +504,7 @@ describe("Read receipts", () => { goTo(room2); assertReadThread("Root"); }); - // XXX: fails because sometimes the room is still unread after opening the thread (initially) + // XXX: fails because it flakes - sometimes the room is still unread after opening the thread (initially) it.skip("Reacting to a redacted message leaves the thread read", () => { // Given a message in a thread was redacted and everything is read goTo(room1); @@ -544,8 +544,7 @@ describe("Read receipts", () => { // Then the room is unread assertStillRead(room2); }); - // XXX: fails because the room still shows "1" even though we have read the thread (stuck unread) - it.skip("Reading a reaction to a redacted message marks the thread as read", () => { + it("Reading a thread after a reaction to a redacted message marks the thread as read", () => { // Given a redacted message in a thread exists, but someone reacted to it before it was redacted goTo(room1); receiveMessages(room2, [ @@ -558,7 +557,7 @@ describe("Read receipts", () => { receiveMessages(room2, [redactionOf("Msg3")]); assertUnread(room2, 2); - // When we read the thread, creating a receipt that points at the reaction + // When we read the thread goTo(room2); openThread("Root");