Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various Analytics changes/fixes/improvements #1046

Merged
merged 3 commits into from Jun 7, 2017
Merged

Conversation

t3chguy
Copy link
Member

@t3chguy t3chguy commented Jun 7, 2017

had a chat with Ben, who showed me the issue of tracking people between analytics on about.riot.im and riot.im itself, as to GA they just look like drop-offs, Piwik has a "Transition Graph" which would be useful in this gap, but it broke when the CustomURLs weren't URLs anymore so this fixes that and also makes clicking on events a little more sane, as it'll take you to that page in riot.im/app though granted with the args redacted.
Also adds tracking of which riot.im instance is being used, i.e /develop/ or `/app/
and the tracking of the action of opting-out, as Matthew had raised a concern that the Analytics seem on the low side, and it could be down to people opting out, this way we will be able to estimate that number.

More importantly, this now tracks only based on the hash, which will be consistent across web and electron so will group the pages more sanely.

We are at the initial limit of 5 custom vars, I'd suggest upping this

…it gets confused when a CustomURL isn't actually a URL (like it wasn't after the latest redaction fixes.

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@matrixbot
Copy link
Member

Can one of the admins verify this patch?

const redactedHash = window.location.hash.replace(/#\/(room|user)\/(.+)/, "#/$1/<redacted>");
return base + redactedHash;
// hardcoded url to make piwik happy
return 'https://riot.im/app/' + redactedHash;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does this need to be hardcoded? It'll be quite confusing if the URLs all say this even if they're actually on /develop/ or even on a different riot instance

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So that a page on one instance is still the same page on another instance as far as piwik can see

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I see. If it's what we want in piwik, fine by me :)

@dbkr dbkr merged commit bfa0951 into develop Jun 7, 2017
@t3chguy t3chguy deleted the t3chguy/piwik_fixes_1 branch October 29, 2017 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants