This repository was archived by the owner on Sep 11, 2024. It is now read-only.
Various Analytics changes/fixes/improvements#1046
Merged
Merged
Conversation
…it gets confused when a CustomURL isn't actually a URL (like it wasn't after the latest redaction fixes. Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Member
|
Can one of the admins verify this patch? |
dbkr
reviewed
Jun 7, 2017
| const redactedHash = window.location.hash.replace(/#\/(room|user)\/(.+)/, "#/$1/<redacted>"); | ||
| return base + redactedHash; | ||
| // hardcoded url to make piwik happy | ||
| return 'https://riot.im/app/' + redactedHash; |
Member
There was a problem hiding this comment.
Why does this need to be hardcoded? It'll be quite confusing if the URLs all say this even if they're actually on /develop/ or even on a different riot instance
Member
Author
There was a problem hiding this comment.
So that a page on one instance is still the same page on another instance as far as piwik can see
Member
There was a problem hiding this comment.
Oh I see. If it's what we want in piwik, fine by me :)
dbkr
approved these changes
Jun 7, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
had a chat with Ben, who showed me the issue of tracking people between analytics on
about.riot.imandriot.imitself, as to GA they just look like drop-offs, Piwik has a "Transition Graph" which would be useful in this gap, but it broke when the CustomURLs weren't URLs anymore so this fixes that and also makes clicking on events a little more sane, as it'll take you to that page inriot.im/appthough granted with the args redacted.Also adds tracking of which riot.im instance is being used, i.e
/develop/or `/app/and the tracking of the action of opting-out, as Matthew had raised a concern that the Analytics seem on the low side, and it could be down to people opting out, this way we will be able to estimate that number.
More importantly, this now tracks only based on the hash, which will be consistent across web and electron so will group the pages more sanely.
We are at the initial limit of 5 custom vars, I'd suggest upping this