Implement button to remove a room from a group #1438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NB: This doesn't provide any feedback to the user. We should use a GroupSummaryStore-style component to refresh the view after a successful hit to the API. This could affect the summary view as well, because when rooms are removed from a group, they are also removed from the summary (if necessary).
dbkr
requested changes
Sep 29, 2017
| e.preventDefault(); | ||
| e.stopPropagation(); | ||
| this.context.matrixClient | ||
| .removeRoomFromGroup(this.props.groupId, this.props.groupRoom.roomId); |
There was a problem hiding this comment.
We should probably get into the habit generally of catching errors & popping up dialogs for them, unless the plan was to get the store to do this once it was written?
There was a problem hiding this comment.
I did forget to catch and put up a dialog. I'm not sure if we can get away with the store doing it, because if we follow the same pattern as GroupSummaryStore, the store would emit an error event. I can see this being annoying if we want to do something following an error in the promise chain.
(Tangentially related: I don't like error dialogs, they're annoying to click away)
| onDeleteClick: function(e) { | ||
| e.preventDefault(); | ||
| e.stopPropagation(); | ||
| this.context.matrixClient |
There was a problem hiding this comment.
This will need a confirmation dialog.
dbkr
approved these changes
Oct 3, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NB: This doesn't provide any feedback to the user. We should use a GroupSummaryStore-style component to refresh the view after a successful hit to the API. This could affect the summary view as well, because when rooms are removed from a group, they are also removed from the summary (if necessary).
CSS at element-hq/element-web#5141