New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Online incremental megolm backups (v2) #2169

Merged
merged 39 commits into from Nov 21, 2018

Conversation

Projects
None yet
3 participants
@dbkr
Copy link
Member

dbkr commented Sep 18, 2018

ara4n and others added some commits Jan 15, 2018

WIP e2e key backups
Continues from Matthew's work: adds a feature flag & panel in
user settings to create a backup.

Can't restore a backup yet, nor even continue backing up to the same
backup after a refresh.

@dbkr dbkr referenced this pull request Sep 18, 2018

Closed

WIP: online incremental megolm backups #1703

0 of 8 tasks complete

@dbkr dbkr changed the base branch from master to develop Sep 18, 2018

@dbkr dbkr changed the title WIP: online incremental megolm backups (v2) Online incremental megolm backups (v2) Oct 30, 2018

* Walks the user through the process of creating an e22 key backup
* on the server.
*/
export default React.createClass({

This comment has been minimized.

@ara4n

ara4n Oct 30, 2018

Member

i don't suggest we change this one, but surely we should be creating new stuff as ES6 at last given the language caught up (and React 16 mandates it?)

This comment has been minimized.

@dbkr

dbkr Oct 31, 2018

Member

Yeah, I guess we should update the code style as I don't think we have

phase: PHASE_GENERATING,
});
// Look, work is being done!
await Promise.delay(1200);

This comment has been minimized.

@ara4n

ara4n Oct 30, 2018

Member

okay, i'm totally missing why we'd want a pregnant pause at this point

This comment has been minimized.

@dbkr

dbkr Oct 31, 2018

Member

This was me making it look like it's doing something to help the user understand the key is being generated rather than just shown to you, which it sort of des if it comes up instantly. Given it's all temporary UI I thought I'd experiment. :)

This comment has been minimized.

This comment has been minimized.

@ara4n

ara4n Nov 9, 2018

Member

ok. might be worth adding the rationale - i.e. to fake a generation


_deleteBackup() {
const QuestionDialog = sdk.getComponent("dialogs.QuestionDialog");
Modal.createTrackedDialog('Delete Backup', '', QuestionDialog, {

This comment has been minimized.

@ara4n

ara4n Oct 30, 2018

Member

minor nit: doublequotes for strings, iirc? rather than flipping back and forth in the same method

This comment has been minimized.

@dbkr

dbkr Oct 31, 2018

Member

Our code style says single by default so I've changed them to be consistent that way (apart from the longer, more English-y ones that are liable to contain apostrophes).

@ara4n

This comment has been minimized.

Copy link
Member

ara4n commented Oct 30, 2018

that's pretty epic, and lgtm other than very minor nits. can't wait to use it!

@ara4n

This comment has been minimized.

Copy link
Member

ara4n commented Nov 9, 2018

lgtm!

dbkr added some commits Nov 20, 2018

Passphrase based key backups
Add passphrase support to backup creation stage
Merge pull request #2284 from matrix-org/dbkr/e2e_backups_download_re…
…covery_key

Add recovery key download button

@dbkr dbkr merged commit d714176 into develop Nov 21, 2018

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
security/snyk - package.json (rxl881) No new issues
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment