Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upDisplay sync status in favicon and title. #221
Conversation
ara4n
reviewed
Mar 16, 2016
| @@ -907,6 +907,11 @@ module.exports = React.createClass({ | ||
| console.warn("Failed to set badge count: "+e.message); | ||
| } | ||
| document.title = "Vector"+(notifCount > 0 ? " ["+notifCount+"]" : ""); | ||
| if(state === "ERROR") { | ||
| this.favicon.badge("×"); |
This comment has been minimized.
This comment has been minimized.
ara4n
Mar 16, 2016
Member
I think this has to be in a try block, as per the previous this.favicon.badge()?
ara4n
reviewed
Mar 16, 2016
| if(state === "ERROR") { | ||
| this.favicon.badge("×"); | ||
| document.title = "Vector [ERROR]"; |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
other than comments inline, this LGTM, thanks! In future, if we get around to updating the badge count locally rather than basing it purely off the |
This comment has been minimized.
This comment has been minimized.
|
@ara4n This should be ready to go; doesn't hide the badge count anymore, instead uses colour to indicate status. |
This comment has been minimized.
This comment has been minimized.
|
thanks! - just merging now. i'd prefer we stick with red badges for the count, but will switch to bright #f00 for the error state and #d00 for normal badge count. |
added a commit
that referenced
this pull request
Mar 16, 2016
aviraldg commentedMar 16, 2016
No description provided.