Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
GitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Pass correct arguments to onFinished in Modal #224
I tried to dig into this last night as part of vector-im/element-web#1121 and got completely stuck - the Modal.js API seems entirely confused here in terms of how it handles onFinished(). @aviraldg: looks like you picked one of the most tangled bits of the codebase for a quick fix - sorry! am working through it IRL with @dbkr now.
Okay - so there were two confusions here:
I've fixed both in #232.
Huge thanks for doing the initial digging on this, and sorry that Modal.js is such a mess. Totally agreed that we urgently need UI-layer tests on vector, via karma or selenium or whatever. Patches welcome...