Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix waste of space of collapsed left panel #2668

Merged
merged 1 commit into from Aug 6, 2019
Merged

Fix waste of space of collapsed left panel #2668

merged 1 commit into from Aug 6, 2019

Conversation

azuenko
Copy link
Contributor

@azuenko azuenko commented Feb 20, 2019

Hello,

I've made a fix to make left panel look more pleasant in collapsed mode. I've tuned some CSS and removed chevron in collapsed mode.

Before

image

After

image

@jryans
Copy link
Collaborator

jryans commented Jul 31, 2019

@azuenko Thanks for making this contribution a while back!

It looks quite nice to me, and it may have slipped through the cracks in our review process. 😭 To move forward, I think we'll need to:

  • Update the PR or each commit with your sign off as described in CONTRIBUTING.rst
  • Fix merge conflicts
  • Design review
  • Code review

If that sounds good, please take a look a updating the PR to fix conflicts, and then we can move forward from there.

Signed-off-by: Anton Zuenko <anton@zuenko.ru>
@azuenko
Copy link
Contributor Author

azuenko commented Aug 6, 2019

Hello @jryans

I've updated the PR: resolved merge conflicts and added signed-off-by tag. Could you please proceed?

Thanks!

@azuenko azuenko changed the title Fix collapsed left panel bad items arrangement Fix waste of space of collapsed left panel Aug 6, 2019
@jryans
Copy link
Collaborator

jryans commented Aug 6, 2019

Great, thanks for continuing with this effort! Next step is a design review. @nadonomy, could you provide design feedback on this?

@jryans jryans requested a review from nadonomy August 6, 2019 11:02
@nadonomy
Copy link
Member

nadonomy commented Aug 6, 2019

Great, thanks for continuing with this effort! Next step is a design review. @nadonomy, could you provide design feedback on this?

This looks great! (And checked the design review in your comment above).

@nadonomy
Copy link
Member

nadonomy commented Aug 6, 2019

@jryans I held off from formally approving the PR via GitHub as the code review is outstanding, but just lmk if you'd prefer me to sign it off via GitHub here.

@turt2live turt2live removed the request for review from nadonomy August 6, 2019 19:52
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good from a code perspective too, thanks!

@turt2live
Copy link
Member

(a green light in the comments is not much different from a green checkmark tbh)

@turt2live turt2live merged commit 610baff into matrix-org:develop Aug 6, 2019
@azuenko azuenko deleted the develop branch August 7, 2019 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants