Simplify settings dialog CSS #2891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stop the settings dialogs from requiring special styles on the mx_Dialog which required passing in a classname from anywhere the settings dialogs were opened (although this still requires static=true). Some of the things have now been adopted for all dialogs (border-radius), others have been moved to within the dialog content.
turt2live
approved these changes
Apr 8, 2019
| max-width: 1000px; | ||
| width: 90vw; | ||
| // set the height too since tabbed view scrolls itself. | ||
| height: 80vh; |
There was a problem hiding this comment.
Personal preference is to have these at the top rather than bottom, but I'm also not sure what our conventions or guidelines say, or if it even matters.
There was a problem hiding this comment.
actually yes, that's probably what I'd expect too
| Modal.createTrackedDialog('User settings', '', UserSettingsDialog, {}, 'mx_SettingsDialog', | ||
| /*isPriority=*/false, /*isStatic=*/true); | ||
| Modal.createTrackedDialog('User settings', '', UserSettingsDialog, {}, | ||
| /*className*/null, /*isPriority=*/false, /*isStatic=*/true); |
There was a problem hiding this comment.
Extremely minor nit: there should be an equal sign after the className to match the others. Same applies to RoomViewStore.
There was a problem hiding this comment.
oh yeah - did not spot that!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stop the settings dialogs from requiring special styles on the
mx_Dialog which required passing in a classname from anywhere the
settings dialogs were opened (although this still requires
static=true). Some of the things have now been adopted for all dialogs
(border-radius), others have been moved to within the dialog content.