Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New design for member panel #3620

merged 37 commits into from Nov 15, 2019

New design for member panel #3620

merged 37 commits into from Nov 15, 2019


Copy link

bwindels commented Nov 15, 2019

Implements vector-im/riot-web#11222
Requires matrix-org/matrix-js-sdk#1072
Fixes vector-im/riot-web#11338

All of this should be hidden behind the feature_user_info_panel feature flag. Shall I make the effort of renaming it to make it clear that this is also about the new design?

As we don't show devices anymore when the room is not encrypted, I added a big "Verify" button in the security section to start the verification through the dialog (the screenshots were made before this button was added).

In general, the commits should be reviewable individually, apart from a few of the last ones that are not entirely in order. sorry about that.


@bwindels bwindels requested a review from matrix-org/riot-web Nov 15, 2019
bwindels added 28 commits Nov 11, 2019
Make it a circle with the profile picture centered,
with a max height/width of 30vh
While we don't have canonical DMs yet,
it takes you to the most recently active DM room
also don't download devices as long as room is not encrypted
as they are only used for verification right now,
and verification events will be unverified by definition,
so no need to alarm users needlessly.

Also, this breaks the bubble layout on hover due to e2e icons
and verified left border style.
still saves when changing the selector though
as the powerlevel on the member is not yet updated at the time is emitted.

Also listen on the client for this event as the currentState
object can change when the timeline is reset.
one while editing (PowerLevelEditor) and one
while not editing (PowerLevelSection).

Also save when pressing the button, not when changing the
power dropdown.

Also show the spinner next to the dropdown when saving,
not at the bottom of the component.
@bwindels bwindels force-pushed the bwindels/userinfomakeover branch from 6f8ce37 to d416ba2 Nov 15, 2019
@dbkr dbkr requested review from dbkr and removed request for matrix-org/riot-web Nov 15, 2019
dbkr approved these changes Nov 15, 2019
Copy link

dbkr left a comment

Looks very plausible! Thanks for doing all the CSS - would have taken me a lot of time & swearing.

res/css/views/rooms/_E2EIcon.scss Outdated Show resolved Hide resolved
src/components/views/elements/IconButton.js Outdated Show resolved Hide resolved
@bwindels bwindels merged commit 41f832a into develop Nov 15, 2019
7 checks passed
7 checks passed
buildkite/matrix-react-sdk Build #3036 passed (6 minutes, 49 seconds)
buildkite/matrix-react-sdk/chains-end-to-end-tests Passed (6 minutes, 30 seconds)
buildkite/matrix-react-sdk/eslint-lint Passed (2 minutes, 11 seconds)
buildkite/matrix-react-sdk/i18n Passed (1 minute, 18 seconds)
buildkite/matrix-react-sdk/karma-tests Passed (6 minutes, 41 seconds)
buildkite/matrix-react-sdk/pipeline Passed (5 seconds)
buildkite/matrix-react-sdk/riot-tests Passed (5 minutes, 59 seconds)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
2 participants
You can’t perform that action at this time.