Change internal font size from from 15 to 10 #4725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… joriks/font-scaling-unit-change
t3chguy
approved these changes
Jun 8, 2020
jryans
added a commit
that referenced
this pull request
Jun 22, 2020
In #4725, we changed the internal font size from 15 to 10, but the `toRem` function (currently only used for read receipts remainders curiously) was not updated. This updates the function, which restores the remainders. Fixes element-hq/element-web#14127
This was referenced Jun 22, 2020
jryans
added a commit
that referenced
this pull request
Jun 22, 2020
In #4725, we changed the internal font size from 15 to 10, but the `toRem` function (currently only used for read receipts remainders curiously) was not updated. This updates the function, which restores the remainders. Fixes element-hq/element-web#14127
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is identical to #4706
We feared that using non integer rem values would cause strange rounding artefacts. We had done some testing which showed that largely this wasn't a worry. However, I've run into the a strange bug on chrome, mac OS (not safari or firefox) which uses a different rounding for vertical and horizontal values. It effects the third decimal significantly. It's usually unoticable but on small circles it's glaring. There was a work around for the toggle switches but now the new radio buttons were looking very disproportionate.
This pr changes our internal base font to 10, making the value of all our $font-Xpx variables a single decimal place long which don't suffer from the rounding problem.
The artefact doesn't show up when you change the base with the slider using the new single decimal place rem values. So, Chrome must be rounding early.
Before:
After:
