Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for pasting files into the text box #605

Merged
merged 1 commit into from Mar 9, 2017

Conversation

vijfhoek
Copy link
Contributor

@vijfhoek vijfhoek commented Jan 8, 2017

Only supports the new rich-text-supporting text editor.

Works on Firefox (51) and Chrome (55). Doesn't work on Safari (10.0.2), although that seems to be a dash.js issue. Needs further investigation.

Fixes element-hq/element-web#1297.

Only supports the new rich-text-supporting text editor
@matrixbot
Copy link
Member

Can one of the admins verify this patch?

@vijfhoek vijfhoek changed the title Add support for pasting into the text box Add support for pasting files into the text box Jan 8, 2017
@thepaka
Copy link

thepaka commented Feb 27, 2017

Hi,
Can someone takes a look on this feature ?
It works (for me) and the code changes seems to be safe to merge.

@ara4n
Copy link
Member

ara4n commented Mar 9, 2017

sorry for the delay in reviewing; was worried that it was RTE-only, but given that RTE is about to land, now is a perfect time to land this too. thanks!

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants