Warn users of E2E key loss when changing/resetting passwords or logging out #646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richvdh
requested changes
Jan 24, 2017
| } | ||
| ); | ||
| var QuestionDialog = sdk.getComponent("dialogs.QuestionDialog"); | ||
| Modal.createDialog(QuestionDialog, { |
There was a problem hiding this comment.
I don't think this is an appropriate place to be popping up the modal - this is supposed to be the low-level interface to MatrixClient. For example, this will appear after the error dialog telling you you've been logged out when your access-token is invalidated.
Please can this go somewhere else and be called when the "Sign out" button is clicked?
also, kill off the inexplicably useless LogoutPrompt in favour of a normal QuestionDialog. This in turn fixes element-hq/element-web#2152
also, kill off the inexplicably useless LogoutPrompt in favour of a normal QuestionDialog. This in turn fixes element-hq/element-web#2152
|
There's a mix here: some legit warnings and other are max-len warnings on the JSX where I'd question the value of limiting to 90 columns. Let's just merge it given matthew's nominally OOO. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses element-hq/element-web#2068
Partially addresses element-hq/element-web#2671