Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ButtonResetDefault from mx_AccessibleButton of EventTile_keyRequestInfo_text #8678

Merged
merged 2 commits into from May 25, 2022
Merged

Remove ButtonResetDefault from mx_AccessibleButton of EventTile_keyRequestInfo_text #8678

merged 2 commits into from May 25, 2022

Conversation

luixxiul
Copy link
Contributor

@luixxiul luixxiul commented May 24, 2022

This PR removes the mixin ButtonResetDefault from mx_AccessibleButton of EventTile_keyRequestInfo_text. It is not required as its declarations except appearance: none (which is not required here too) are inherited from rules of AccessibleButton.

Before After
before1 after1
before2 after2

Signed-off-by: Suguru Hirahara luixxiul@users.noreply.github.com

type: task


This change is marked as an internal change (Task), so will not be included in the changelog.

…questInfo_text

To respect the concept of cascading. Also using a mixin to unset the declarations can easily cause a style inconsistency.

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
@github-actions github-actions bot added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label May 24, 2022
@luixxiul luixxiul marked this pull request as ready for review May 24, 2022 13:07
@luixxiul luixxiul requested a review from a team as a code owner May 24, 2022 13:07
Copy link
Contributor

@weeman1337 weeman1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution @luixxiul

Tested, works, LGTM 👍

@weeman1337 weeman1337 merged commit 03c2bdb into matrix-org:develop May 25, 2022
@luixxiul luixxiul deleted the EventTile_keyRequestInfo_text_AccessibleButton branch May 25, 2022 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants