Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc @room notifications #1033

Closed
dbkr opened this issue Oct 23, 2017 · 3 comments
Closed

Doc @room notifications #1033

dbkr opened this issue Oct 23, 2017 · 3 comments
Labels
kind:core MSC which is critical to the protocol's success merged A proposal whose PR has merged into the spec! proposal A matrix spec change proposal spec-omission implemented but not currently specified

Comments

@dbkr
Copy link
Member

dbkr commented Oct 23, 2017

Documentation: https://docs.google.com/document/d/1qRdlg94cr9YXxPCwhW4HgI2oDrqQOUKX5HptZFBGf6o/edit#

ie. the sender_notification_permission pushrule condition.

@turt2live
Copy link
Member

Can the doc made public for viewing please?

@richvdh
Copy link
Member

richvdh commented Oct 25, 2017

doc perms fixed, I hope

@richvdh richvdh added the spec-omission implemented but not currently specified label Oct 25, 2017
@richvdh
Copy link
Member

richvdh commented Dec 29, 2017

see also #1101 which is about the power_levels for this I think

@richvdh richvdh added spec-pr-missing Proposal has been implemented and is being used in the wild but hasn't yet been added to the spec proposal A matrix spec change proposal labels May 31, 2018
@turt2live turt2live added this to To do: proposals (prioritized) in August 2018 r0 Aug 14, 2018
@turt2live turt2live moved this from To do: proposals (prioritized) to In review in August 2018 r0 Aug 14, 2018
turt2live added a commit to turt2live/matrix-doc that referenced this issue Aug 22, 2018
This commit does a few things:
* Add 3 undocumented push rules to the spec for encrypted events and at-room notifications.
* Require unrecognized conditions to not match, ensuring that future conditions do not cause clients to accidentally notify users.
* Clarify that push rules should be enabled when created.
* Document a new condition required for at-room notifications.

Fixes matrix-org#1163
Fixes matrix-org#1034
Fixes matrix-org#676
Fixes matrix-org#1033
Relates to matrix-org#1101
@turt2live turt2live moved this from In review to In review (just the issues) in August 2018 r0 Aug 24, 2018
August 2018 r0 automation moved this from In review (just the issues) to Done (this list will be incomplete) Aug 27, 2018
@richvdh richvdh added merged A proposal whose PR has merged into the spec! and removed spec-pr-missing Proposal has been implemented and is being used in the wild but hasn't yet been added to the spec labels Aug 30, 2018
@turt2live turt2live added the kind:core MSC which is critical to the protocol's success label Apr 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:core MSC which is critical to the protocol's success merged A proposal whose PR has merged into the spec! proposal A matrix spec change proposal spec-omission implemented but not currently specified
Projects
No open projects
August 2018 r0
  
Done (this list will be incomplete)
Development

No branches or pull requests

3 participants