Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MSC1797: Proposal for more granular profile error codes #1797

Open
wants to merge 2 commits into
base: old_master
Choose a base branch
from
Open

MSC1797: Proposal for more granular profile error codes #1797

wants to merge 2 commits into from

Conversation

turt2live
Copy link
Member

@turt2live turt2live added proposal-in-review proposal A matrix spec change proposal labels Jan 11, 2019
@turt2live turt2live changed the title Proposal for more granular profile error codes MSC1797: Proposal for more granular profile error codes Jan 11, 2019
turt2live added a commit to matrix-org/matrix-react-sdk that referenced this pull request Jan 11, 2019
@turt2live
Give a route for retrying invites for users which may not exist
5333114 
Fixes element-hq/element-web#7922

This supports the current style of errors (M_NOT_FOUND) as well as the errors presented by MSC1797: matrix-org/matrix-spec-proposals#1797
@turt2live turt2live mentioned this pull request Jan 11, 2019
Merged
@jryans
Copy link
Contributor

jryans commented Jan 11, 2019

This proposal makes sense to me.

@ara4n
Copy link
Member

ara4n commented Jan 11, 2019

lgtm other than the quibble on UNKNOWN wording

Half-Shot
Half-Shot requested changes Jan 13, 2019
View reviewed changes
Copy link
Contributor

@Half-Shot Half-Shot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than M_PROFILE_UNDISCLOSED, this proposal seems sane.

proposals/1797-profile-error-codes.md Show resolved Hide resolved
@richvdh richvdh self-requested a review January 14, 2019 11:56
Half-Shot
Half-Shot reviewed Jan 14, 2019
View reviewed changes
Copy link
Contributor

@Half-Shot Half-Shot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Concerns addressed.

@richvdh richvdh removed their request for review January 14, 2019 23:10
@turt2live turt2live mentioned this pull request Feb 18, 2020
Closed
@turt2live turt2live added the kind:maintenance MSC which clarifies/updates existing spec label Apr 20, 2020
@turt2live turt2live added the needs-implementation This MSC does not have a qualifying implementation for the SCT to review. The MSC cannot enter FCP. label Jun 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ara4n ara4n ara4n left review comments

@Half-Shot Half-Shot Half-Shot approved these changes

Assignees
No one assigned
Labels
kind:maintenance MSC which clarifies/updates existing spec needs-implementation This MSC does not have a qualifying implementation for the SCT to review. The MSC cannot enter FCP. proposal A matrix spec change proposal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@turt2live @jryans @ara4n @Half-Shot