MSC1797: Proposal for more granular profile error codes #1797
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turt2live
changed the title
turt2live
added a commit
to matrix-org/matrix-react-sdk
that referenced
this pull request
Jan 11, 2019
Fixes element-hq/element-web#7922 This supports the current style of errors (M_NOT_FOUND) as well as the errors presented by MSC1797: matrix-org/matrix-spec-proposals#1797
Contributor
|
This proposal makes sense to me. |
ara4n
reviewed
Jan 11, 2019
Member
|
lgtm other than the quibble on UNKNOWN wording |
Half-Shot
requested changes
Jan 13, 2019
Contributor
Half-Shot
left a comment
Half-Shot
left a comment
There was a problem hiding this comment.
Other than M_PROFILE_UNDISCLOSED, this proposal seems sane.
Half-Shot
approved these changes
Jan 18, 2019
turt2live
added
the
needs-implementation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rendered