Render enums inside additionalProps as one more table #2245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I wonder if a changelog entry should be supplied with this. |
|
Yes, it should. Probably something like "Clarify the available enum values for the room versions capability". |
Co-Authored-By: Travis Ralston <travpc@gmail.com>
|
(dev scripts build failure is probably a false positive - try merging master into your branch and it should go away) |
|
Seems like we're good to go now? |
|
Yup! |
|
This part of the spec has actually become worse with 0.6.1, and it does seem to be because of this change. There is no longer anything tying before: after: |
|
@jplatte that's probably a simple typing error on our part. Please open a new issue instead of commenting on closed/merged changes, as we typically will not notice. |
This was referenced Jun 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
/capabilitiesusesadditionalPropertiesthat maps to an enum value. The code parsingadditionalPropertiesalmost doesn't use the Swagger data on the enum, leading to #2242. This PR adds rendering the data on enum into another table.