Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render enums inside additionalProps as one more table #2245

Merged

Conversation

KitsuneRal
Copy link
Member

@KitsuneRal KitsuneRal commented Aug 24, 2019

/capabilities uses additionalProperties that maps to an enum value. The code parsing additionalProperties almost doesn't use the Swagger data on the enum, leading to #2242. This PR adds rendering the data on enum into another table.

@turt2live turt2live self-requested a review Aug 24, 2019
@KitsuneRal
Copy link
Member Author

KitsuneRal commented Aug 25, 2019

I wonder if a changelog entry should be supplied with this.

@turt2live
Copy link
Member

turt2live commented Aug 25, 2019

Yes, it should. Probably something like "Clarify the available enum values for the room versions capability".

Copy link
Member

@turt2live turt2live left a comment

otherwise lgtm - thanks for fixing

changelogs/client_server/2245.clarification Outdated Show resolved Hide resolved
Co-Authored-By: Travis Ralston <travpc@gmail.com>
@turt2live
Copy link
Member

turt2live commented Oct 3, 2019

(dev scripts build failure is probably a false positive - try merging master into your branch and it should go away)

@KitsuneRal
Copy link
Member Author

KitsuneRal commented Oct 3, 2019

Seems like we're good to go now?

@turt2live
Copy link
Member

turt2live commented Oct 3, 2019

Yup!

@turt2live turt2live merged commit 500db6f into matrix-org:master Oct 3, 2019
7 checks passed
@KitsuneRal KitsuneRal deleted the kitsune-map-to-enum-support branch Nov 10, 2019
@jplatte
Copy link
Member

jplatte commented May 31, 2020

This part of the spec has actually become worse with 0.6.1, and it does seem to be because of this change. There is no longer anything tying RoomVersionStability to RoomVersionsCapability.

before: room_versions_0 6 0

after: room_versions_0 6 1

@turt2live
Copy link
Member

turt2live commented Jun 1, 2020

@jplatte that's probably a simple typing error on our part. Please open a new issue instead of commenting on closed/merged changes, as we typically will not notice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants