Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename nonce to txn_id. Reorganize for clarity. #2369

Merged
merged 3 commits into from Dec 7, 2019
Merged

Rename nonce to txn_id. Reorganize for clarity. #2369

merged 3 commits into from Dec 7, 2019

Conversation

iinuwa
Copy link
Contributor

@iinuwa iinuwa commented Nov 29, 2019

It seems that nonce was renamed to txn_id in 97154cc, but it wasn't updated in the description text below. Also, some of the information about the token was interlaced with the information describing the txn_id. I I reorganized it to have the related content grouped together.

If someone has an opinion on whether the paragraph starting with "Additionally, " should be part of the paragraph above, that'd be good. I separated it since it was originally separate from the token description and seems to be answering the question "Why isn't the user id in the auth object?" rather than a token-specific question.

Signed-Off-By: Isaiah Inuwa isaiah.inuwa@gmail.com

Signed-Off-By: Isaiah Inuwa <isaiah.inuwa@gmail.com>
@turt2live turt2live self-requested a review Nov 29, 2019
@turt2live turt2live merged commit 21b50d7 into matrix-org:master Dec 7, 2019
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants