MSC2391: Federation point-queries.#2391
Open
tulir wants to merge 2 commits intomatrix-org:old_masterfrom
Open
Conversation
turt2live
reviewed
Dec 19, 2019
ShadowJonathan
suggested changes
Apr 12, 2021
Contributor
ShadowJonathan
left a comment
ShadowJonathan
left a comment
There was a problem hiding this comment.
I think this is an interesting feature to have "as a nice thing", but i think this is missing some major pieces to address security and the like with.
| @@ -0,0 +1,35 @@ | |||
| # MSC2391 - Efficient point-queries for Room state over Federation | |||
Contributor
There was a problem hiding this comment.
Shouldn't this have a "Security Considerations" heading? I think that this MSC trusts other servers too much for something like this, as you then effectively trust other servers to not give you bogus state events.
turt2live
added
the
needs-implementation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Author: @jevolk
Rendered