Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix key export format example #2430

Merged
merged 1 commit into from Feb 6, 2020
Merged

Conversation

deepbluev7
Copy link
Contributor

@deepbluev7 deepbluev7 commented Feb 5, 2020

Signed-off-by: Nicolas Werner nicolas.werner@hotmail.de

Some "errors" were fixed in the spec in #1939 to let the format match, what riot uses to export session keys. Sadly the example was forgotten to be fixed and having the wrong example could make it easy to misunderstand the spec at that location. I actually introduced a bug in nheko, that broke key import, through a bad copy and paste when refactoring. Took me a while to figure out, why I couldn't import session keys from riot anymore, since the parser matched the example in the spec... Well, this should prevent that from happening again!

@uhoreg uhoreg self-requested a review Feb 6, 2020
@uhoreg
Copy link
Member

uhoreg commented Feb 6, 2020

Can you add a changelogs/client_server/newsfragments/2430.clarification file? (with the appropriate contents, of course) Thanks.

Signed-off-by: Nicolas Werner <nicolas.werner@hotmail.de>
@deepbluev7 deepbluev7 force-pushed the mmaster branch 2 times, most recently from a610190 to 6911171 Compare Feb 6, 2020
uhoreg
uhoreg approved these changes Feb 6, 2020
Copy link
Member

@uhoreg uhoreg left a comment

Looks good! Thanks for your contribution!

@uhoreg uhoreg merged commit c79ed36 into matrix-org:master Feb 6, 2020
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants