Fix key export format example #2430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you add a |
Signed-off-by: Nicolas Werner <nicolas.werner@hotmail.de>
deepbluev7
force-pushed
the
mmaster
branch
2 times, most recently
from
a610190
to
6911171
Compare
19 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Signed-off-by: Nicolas Werner nicolas.werner@hotmail.de
Some "errors" were fixed in the spec in #1939 to let the format match, what riot uses to export session keys. Sadly the example was forgotten to be fixed and having the wrong example could make it easy to misunderstand the spec at that location. I actually introduced a bug in nheko, that broke key import, through a bad copy and paste when refactoring. Took me a while to figure out, why I couldn't import session keys from riot anymore, since the parser matched the example in the spec... Well, this should prevent that from happening again!